linux-kernel - Re: [PATCH 1/5] kernel: Move kernel_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wg+q2KWMzw1XG_p8=taG1UaiiuUEeCJ4wmX+xrHi=CV6Q@mail.gmail.com>
Date:   Mon, 13 Feb 2023 11:57:12 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Mike Christie <michael.christie@...cle.com>
Cc:     brauner@...nel.org, ebiederm@...ssion.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] kernel: Move kernel_clone_args's fn to new struct

On Sun, Feb 12, 2023 at 5:00 PM Mike Christie
<michael.christie@...cle.com> wrote:
>
> The next patches will add callouts to set the task's comm, and create
> internal resources. This adds a new struct to for these callouts to
> organize them and reduce the args passed into kernel_thread and
> create_io_thread.

This patch too seems to just make things more complicated for no reason.

When the point was to make things simpler, adding a (pointless)
indirection through another structure seems to be against the whole
idea.

The code is neither simpler not more legible. Quite the reverse.

            Linus