linux-kernel - Re: [PATCH] EDAC/amd64: remove unneeded call to reserve_mc_sibling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+qcU2M5gchfzbky@zn.tnic>
Date:   Mon, 13 Feb 2023 21:23:47 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Yazen Ghannam <yazen.ghannam@....com>
Cc:     Tom Rix <trix@...hat.com>, Nathan Chancellor <nathan@...nel.org>,
        tony.luck@...el.com, james.morse@....com, mchehab@...nel.org,
        rric@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC/amd64: remove unneeded call to
 reserve_mc_sibling_devs()

On Mon, Feb 13, 2023 at 08:12:38PM +0000, Yazen Ghannam wrote:
> These errors are encountered when extra warnings are enabled, correct?

It says so in the warning which one it is: -Werror,-Wsometimes-uninitialized

Don't know if we enable that one for clang with W= or Nathan adds
additional switches.

> I think the following patch would resolve this issue. This is part of a set
> that isn't fully applied.
> https://lore.kernel.org/linux-edac/20230127170419.1824692-12-yazen.ghannam@amd.com/
> 
> Boris,
> Do you think one of these patches should be applied or just hold off until the
> entire original set is applied?

I still wanted to go through the rest but I'm not sure I'll have time
for it before the merge window. So unless this is breaking some silly
testing scenario, I'd say I'll leave things as they are.

Once I take yours, that silly false positive will go away and we can
forget about it.

> As for myself, I'll start including builds with extra warnings enabled
> for each patch in my workflow. Currently I do a regular build for each
> patch and a build with extra warnings for the entire set.

Dunno, I'd say with false positives we have bigger fish to fry...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette