lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 13 Feb 2023 21:53:21 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     ChiaEn Wu <chiaen_wu@...htek.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        cy_huang@...htek.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        peterwu.pub@...il.com
Subject: Re: [Patch][next] dt-bindings: power: supply: Revise Richtek RT9467
 compatible name

Hi,

On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> "richtek,rt9467"
> 
> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> Signed-off-by: ChiaEn Wu <chiaen_wu@...htek.com>
> ---

Is there a new version of this fixing the issues pointed out by Krzysztof?
Also I think the filename and $id should be changed to richtek,rt9467.yaml
in addition to the compatible change.

Thanks,

-- Sebastian

>  .../devicetree/bindings/power/supply/richtek,rt9467-charger.yaml      | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
> index 92c5706..9176808 100644
> --- a/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
> @@ -25,7 +25,7 @@ description: |
>  
>  properties:
>    compatible:
> -    const: richtek,rt9467-charger
> +    const: richtek,rt9467
>  
>    reg:
>      maxItems: 1
> @@ -65,7 +65,7 @@ examples:
>        #size-cells = <0>;
>  
>        charger@5b {
> -        compatible = "richtek,rt9467-charger";
> +        compatible = "richtek,rt9467";
>          reg = <0x5b>;
>          wakeup-source;
>          interrupts-extended = <&gpio_intc 32 IRQ_TYPE_LEVEL_LOW>;
> -- 
> 2.7.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ