[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230213212733.rhvuzrshfrvzgo4a@mercury.elektranox.org>
Date: Mon, 13 Feb 2023 22:27:33 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, andersson@...nel.org,
agross@...nel.org, krzysztof.kozlowski@...aro.org,
marijn.suijten@...ainline.org, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't
require charging properties
Hi,
On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote:
> It's fine for these properties to be absent, as the driver doesn't fail
> without them and functions with settings inherited from the reset/previous
> stage bootloader state.
>
> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
Please update the description of these properties to describe the
default behaviour.
-- Sebastian
> .../devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> index b7b58aed3f3c..d62e3af55560 100644
> --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> @@ -43,8 +43,6 @@ properties:
> required:
> - compatible
> - reg
> - - qcom,rset-ohms
> - - qcom,vset-millivolts
>
> additionalProperties: false
>
> --
> 2.39.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists