linux-kernel - [PATCH 2/5] kernel: Add kernel_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230213010020.1813-3-michael.christie@oracle.com>
Date:   Sun, 12 Feb 2023 19:00:17 -0600
From:   Mike Christie <michael.christie@...cle.com>
To:     brauner@...nel.org, ebiederm@...ssion.com,
        torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Cc:     Mike Christie <michael.christie@...cle.com>
Subject: [PATCH 2/5] kernel: Add kernel_clone_fns function to setup task

The io_uring code will set it's worker threads's name with a
iou-sqd/iou-wrk prefix and then either the task's pid or the task's
parent's pid. The kthread code will set the name to whatever the caller
decides. To set these names they have come up with different approaches.

This patch adds a callout to setup a kthread or io_uring worker's
internal struct and/or set the task's coomm.

Signed-off-by: Mike Christie <michael.christie@...cle.com>
---
 include/linux/sched.h      | 2 ++
 include/linux/sched/task.h | 1 +
 kernel/fork.c              | 6 ++++++
 3 files changed, 9 insertions(+)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 853d08f7562b..09bdc71c0523 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1066,6 +1066,8 @@ struct task_struct {
 	 * executable name, excluding path.
 	 *
 	 * - normally initialized setup_new_exec()
+	 * - can be initialized in copy_process if
+	 *   kernel_clone_args.fns.setup_thread_fn() is set.
 	 * - access it with [gs]et_task_comm()
 	 * - lock it with task_lock()
 	 */
diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 7a61ebbcdfe0..844824e0023c 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -20,6 +20,7 @@ struct css_set;
 
 struct kernel_clone_fns {
 	int (*thread_fn)(void *fn_arg);
+	int (*setup_thread_fn)(struct task_struct *tsk, void *fn_arg);
 };
 
 struct kernel_clone_args {
diff --git a/kernel/fork.c b/kernel/fork.c
index f308a5ae0ed3..057274da64fb 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2345,6 +2345,12 @@ static __latent_entropy struct task_struct *copy_process(
 		p->tgid = p->pid;
 	}
 
+	if (args->fns && args->fns->setup_thread_fn) {
+		retval = args->fns->setup_thread_fn(p, args->fn_arg);
+		if (retval)
+			goto bad_fork_put_pidfd;
+	}
+
 	p->nr_dirtied = 0;
 	p->nr_dirtied_pause = 128 >> (PAGE_SHIFT - 10);
 	p->dirty_paused_when = 0;
-- 
2.25.1