lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230213224540.o4fd554ippzdej7a@mercury.elektranox.org>
Date:   Mon, 13 Feb 2023 23:45:40 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, andersson@...nel.org,
        agross@...nel.org, krzysztof.kozlowski@...aro.org,
        marijn.suijten@...ainline.org, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't
 require charging properties

Hi,

On Mon, Feb 13, 2023 at 10:41:10PM +0100, Konrad Dybcio wrote:
> On 13.02.2023 22:27, Sebastian Reichel wrote:
> > On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote:
> >> It's fine for these properties to be absent, as the driver doesn't fail
> >> without them and functions with settings inherited from the reset/previous
> >> stage bootloader state.
> >>
> >> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> >> ---
> > Please update the description of these properties to describe the
> > default behaviour.
> Not sure if there's any default behavior other than "go with
> whatever was there previously, no matter how it got there".

I got that from the patch description, but that behaviour should be
described in the binding.

> Is it okay if I just add:
> 
> "If unspecified, inherit the bootloader configuration"

Technically the bindings are also for bootloaders. I suggest:

If unspecified, inherit the previous configuration (e.g. from
bootloader or hardware default value).

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ