linux-kernel - drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:1580 rtl8xxxu_print_chipinfo() warn: always true condition '(priv->chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2023 07:24:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bitterblue Smith <rtl8821cerfe2@...il.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Kalle Valo <kvalo@...nel.org>
Subject: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:1580
 rtl8xxxu_print_chipinfo() warn: always true condition '(priv->chip_cut <=
 15) => (0-15 <= 15)'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b408817d48840847c00052ae0e02a54311913073
commit: 7b0ac469e331d9f9fd77f4ebb7a6322f5562db67 wifi: rtl8xxxu: Recognise all possible chip cuts
date:   3 months ago
config: x86_64-randconfig-m001-20230213 (https://download.01.org/0day-ci/archive/20230214/202302140753.71IgU77A-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302140753.71IgU77A-lkp@intel.com/

New smatch warnings:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:1580 rtl8xxxu_print_chipinfo() warn: always true condition '(priv->chip_cut <= 15) => (0-15 <= 15)'

Old smatch warnings:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5675 rtl8xxxu_c2hcmd_callback() warn: potential spectre issue 'rtl8xxxu_legacy_ratetable' [r] (local cap)

vim +1580 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c

  1573	
  1574	static void rtl8xxxu_print_chipinfo(struct rtl8xxxu_priv *priv)
  1575	{
  1576		struct device *dev = &priv->udev->dev;
  1577		char cut = '?';
  1578	
  1579		/* Currently always true: chip_cut is 4 bits. */
> 1580		if (priv->chip_cut <= 15)
  1581			cut = 'A' + priv->chip_cut;
  1582	
  1583		dev_info(dev,
  1584			 "RTL%s rev %c (%s) %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n",
  1585			 priv->chip_name, cut, priv->chip_vendor, priv->tx_paths,
  1586			 priv->rx_paths, priv->ep_tx_count, priv->has_wifi,
  1587			 priv->has_bluetooth, priv->has_gps, priv->hi_pa);
  1588	
  1589		dev_info(dev, "RTL%s MAC: %pM\n", priv->chip_name, priv->mac_addr);
  1590	}
  1591	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests