linux-kernel - Re: [PATCH] xen/pvcalls-back: fix permanently masked event channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc9269b1-c91e-86d1-fd6d-9a3ffddf3ed9@suse.com>
Date:   Mon, 13 Feb 2023 09:19:28 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Volodymyr Babchuk <Volodymyr_Babchuk@...m.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Stefano Stabellini <sstabellini@...nel.org>
Cc:     "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Oleksii Moisieiev <Oleksii_Moisieiev@...m.com>
Subject: Re: [PATCH] xen/pvcalls-back: fix permanently masked event channel

On 19.01.23 22:11, Volodymyr Babchuk wrote:
> There is a sequence of events that can lead to a permanently masked
> event channel, because xen_irq_lateeoi() is newer called. This happens
> when a backend receives spurious write event from a frontend. In this
> case pvcalls_conn_back_write() returns early and it does not clears the
> map->write counter. As map->write > 0, pvcalls_back_ioworker() returns
> without calling xen_irq_lateeoi(). This leaves the event channel in
> masked state, a backend does not receive any new events from a
> frontend and the whole communication stops.
> 
> Move atomic_set(&map->write, 0) to the very beginning of
> pvcalls_conn_back_write() to fix this issue.
> 
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@...m.com>
> Reported-by: Oleksii Moisieiev <oleksii_moisieiev@...m.com>

Pushed to: xen/tip.git for-linus-6.3


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)