linux-kernel - Re: [PATCH] drm/meson/meson_venc: Relax the supported mode checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <447fa1c7-4992-838f-b5cd-91245deae188@baylibre.com>
Date:   Mon, 13 Feb 2023 10:15:35 +0100
From:   Carlo Caione <ccaione@...libre.com>
To:     Da Xue <da@...sconfused.com>
Cc:     Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-arm-kernel@...ts.infradead.org,
        "open list:ARM/Amlogic Meson..." <linux-amlogic@...ts.infradead.org>,
        dri-devel@...ts.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/meson/meson_venc: Relax the supported mode checks

On 13/02/2023 08:09, Da Xue wrote:

>     -       if (mode->hdisplay < 640 || mode->hdisplay > 1920)
>     +       if (mode->hdisplay < 480 || mode->hdisplay > 1920)
>                      return MODE_BAD_HVALUE;
> 
>     -       if (mode->vdisplay < 480 || mode->vdisplay > 1200)
>     +       if (mode->vdisplay < 480 || mode->vdisplay > 1920)
>                      return MODE_BAD_VVALUE;
> 
> Should these be lowered to 400 instead of 480?

If you want to support 400x1280 then we need to tweak mode->hdisplay as 
well.

I'll push a v2.

-- 
Carlo Caione