linux-kernel - Re: [PATCH] swiotlb: fix the deadlock in swiotlb_do_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36c2bc37-714b-2251-942f-1d02f4b77d5a@linux.alibaba.com>
Date:   Mon, 13 Feb 2023 17:35:47 +0800
From:   Guorui Yu <GuoRui.Yu@...ux.alibaba.com>
To:     kernel test robot <lkp@...el.com>, hch@....de,
        m.szyprowski@...sung.com
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        robin.murphy@....com, iommu@...ts.linux.dev,
        linux-kernel@...r.kernel.org, xiaokang.hxk@...baba-inc.com
Subject: Re: [PATCH] swiotlb: fix the deadlock in swiotlb_do_find_slots



在 2023/2/13 17:28, kernel test robot 写道:
> Hi GuoRui.Yu",
> 
> Thank you for the patch! Perhaps something to improve:
> 
>     654		spin_lock_irqsave(&area->lock, flags);
>     655		if (unlikely(nslots > mem->area_nslabs - area->used))
>     656			goto not_found;
>     657	
>     658		slot_base = area_index * mem->area_nslabs;
>     659		index = wrap = wrap_area_index(mem, ALIGN(area->index, stride));
index_nowrap should be initialized to "index" here, and I will add this 
in v2.

I have done some stress tests locally to check if they can avoid the 
deadlock but they did not reveal this problem, I will pay more attention 
next time.
>     660	
>     661		do {

Guorui