linux-kernel - Re: copy on write for splice() from file to pipe?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+oCBnz2nLtXrz7O@gondor.apana.org.au>
Date:   Mon, 13 Feb 2023 17:25:26 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Dave Chinner <david@...morbit.com>
Cc:     torvalds@...ux-foundation.org, metze@...ba.org, axboe@...nel.dk,
        linux-fsdevel@...r.kernel.org, linux-api@...r.kernel.org,
        io-uring@...r.kernel.org, linux-kernel@...r.kernel.org,
        viro@...iv.linux.org.uk, samba-technical@...ts.samba.org
Subject: Re: copy on write for splice() from file to pipe?

Dave Chinner <david@...morbit.com> wrote:
>
> IOWs, the application does not care if the data changes whilst they
> are in transport attached to the pipe - it only cares that the
> contents are stable once they have been delivered and are now wholly
> owned by the network stack IO path so that the OTW encodings
> (checksum, encryption, whatever) done within the network IO path
> don't get compromised.

Is this even a real problem? The network stack doesn't care at
all if you modify the pages while it's being processed.  All the
things you've mentioned (checksum, encryption, etc.) will be
self-consistent on the wire.

Even when actual hardware offload is involved it's hard to see how
things could possibly go wrong unless the hardware was going out of
its way to do the wrong thing by fetching from memory twice.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt