linux-kernel - Re: [PATCH 0/3] Extend logging on TMC start / stop errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Feb 2023 10:07:04 +0000
From:   James Clark <james.clark@....com>
To:     Mike Leach <mike.leach@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org,
        linux-kernel@...r.kernel.org
Cc:     mathieu.poirier@...aro.org, yabinc@...gle.com
Subject: Re: [PATCH 0/3] Extend logging on TMC start / stop errors



On 10/02/2023 15:10, Mike Leach wrote:
> Recent issues with trying to debug TMC timeouts and flush issues shows
> a general lack of logging and context around the possible errors
> 
> Patchset addresses that.
> 
> Signed-off-by: Mike Leach <mike.leach@...aro.org>
> 
> Mike Leach (3):
>   coresight: Update timeout functions to allow return of test register
>     value
>   coresight: tmc: Update error logging in tmc common functions
>   coresight: etf: etr: Update logging around flush_and_stop() errors
> 
>  drivers/hwtracing/coresight/coresight-core.c  | 50 +++++++++++++++----
>  .../hwtracing/coresight/coresight-tmc-core.c  | 37 +++++++++++---
>  .../hwtracing/coresight/coresight-tmc-etf.c   | 12 +++--
>  .../hwtracing/coresight/coresight-tmc-etr.c   |  8 ++-
>  drivers/hwtracing/coresight/coresight-tmc.h   |  2 +-
>  include/linux/coresight.h                     | 10 +++-
>  6 files changed, 93 insertions(+), 26 deletions(-)
> 

Looks good to me.

Reviewed-by: James Clark <james.clark@....com>

At some point I might go and add some TRACE_EVENT(coresight_...)s around
things like enabling and disabling devices. It might help to see what
led up to an error rather than just the error itself.