linux-kernel - Re: [PATCH v2 09/18] lib/stackdepot: rename slab to pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG_fn=VHAJ4tyVeEv4ZUcP9eAt7+Teatgfu6APdEDM6J1jqGhQ@mail.gmail.com>
Date:   Mon, 13 Feb 2023 11:35:28 +0100
From:   Alexander Potapenko <glider@...gle.com>
To:     Vlastimil Babka <vbabka@...e.cz>
Cc:     andrey.konovalov@...ux.dev, Marco Elver <elver@...gle.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        kasan-dev@...glegroups.com, Evgenii Stepanov <eugenis@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Andrey Konovalov <andreyknvl@...gle.com>
Subject: Re: [PATCH v2 09/18] lib/stackdepot: rename slab to pool

On Mon, Feb 13, 2023 at 11:20 AM Vlastimil Babka <vbabka@...e.cz> wrote:
>
> On 2/10/23 22:15, andrey.konovalov@...ux.dev wrote:
> > From: Andrey Konovalov <andreyknvl@...gle.com>
> >
> > Use "pool" instead of "slab" for naming memory regions stack depot
> > uses to store stack traces. Using "slab" is confusing, as stack depot
> > pools have nothing to do with the slab allocator.
> >
> > Also give better names to pool-related global variables: change
> > "depot_" prefix to "pool_" to point out that these variables are
> > related to stack depot pools.
> >
> > Also rename the slabindex (poolindex) field in handle_parts to pool_index
> > to align its name with the pool_index global variable.
> >
> > No functional changes.
> >
> > Signed-off-by: Andrey Konovalov <andreyknvl@...gle.com>
>
> Acked-by: Vlastimil Babka <vbabka@...e.cz>
Reviewed-by: Alexander Potapenko <glider@...gle.com>