[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <101940e8-c149-dd81-4abc-2a1479c19a9f@linaro.org>
Date: Mon, 13 Feb 2023 12:15:55 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Janne Grunau <j@...nau.net>, Hector Martin <marcan@...can.st>,
Sven Peter <sven@...npeter.dev>,
Alyssa Rosenzweig <alyssa@...enzweig.io>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Mark Kettenis <kettenis@...nbsd.org>
Cc: asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/17] dt-bindings: arm: apple: Add t8112 j413/j473/j493
compatibles
On 12/02/2023 16:41, Janne Grunau wrote:
> This adds the following apple,t8112 platforms:
>
> - apple,j413 - MacBook Air (M2, 2022)
> - apple,j473 - Mac mini (M2, 2023)
> - apple,j493 - MacBook Pro (13-inch, M2, 2022)
>
> Signed-off-by: Janne Grunau <j@...nau.net>
> ---
> Documentation/devicetree/bindings/arm/apple.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml
> index da78c69774f2..883fd67e3752 100644
> --- a/Documentation/devicetree/bindings/arm/apple.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple.yaml
> @@ -19,6 +19,12 @@ description: |
> - MacBook Air (M1, 2020)
> - iMac (24-inch, M1, 2021)
>
> + Devices based on the "M2" SoC:
> +
> + - MacBook Air (M2, 2022)
> + - MacBook Pro (13-inch, M2, 2022)
> + - Mac mini (M2, 2023)
Aren't you now repeating exactly what is in the schema? Keep only one...
> +
> And devices based on the "M1 Pro", "M1 Max" and "M1 Ultra" SoCs:
>
> - MacBook Pro (14-inch, M1 Pro, 2021)
> @@ -70,6 +76,15 @@ properties:
> - const: apple,t8103
> - const: apple,arm-platform
>
> + - description: Apple M2 SoC based platforms
> + items:
> + - enum:
> + - apple,j413 # MacBook Air (M2, 2022)
> + - apple,j473 # Mac mini (M2, 2023)
> + - apple,j493 # MacBook Pro (13-inch, M2, 2022)
Best regards,
Krzysztof
Powered by blists - more mailing lists