linux-kernel - RE: [PATCH v5 1/1] tty: n_gsm: add keep alive support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB9PR10MB5881C08001D7FA76D6E2C06CE0DD9@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
Date:   Mon, 13 Feb 2023 11:32:47 +0000
From:   "Starke, Daniel" <daniel.starke@...mens.com>
To:     "m.brock@...mierlo.com" <m.brock@...mierlo.com>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 1/1] tty: n_gsm: add keep alive support

> > From: Daniel Starke <daniel.starke@...mens.com>
> > +	u32 keep_alive;		/* Control channel keep-alive in ms */
> [...]
> > +		if (dlci && !dlci->dead)
> > +			mod_timer(&gsm->ka_timer, jiffies + gsm->keep_alive * HZ / 100);
> 
> keep-alive is in ms? or in 10ms?

Good found. The comment is wrong. It is in 10ms as also written in the
comment for "keep_alive" within gsmmux.h to be in line with t1 and t2.
I will correct this for v6 of the patch.

Best regards,
Daniel Starke