linux-kernel - Re: [PATCH 02/17] dt-bindings: arm: apple: apple,pmgr: Add t8112-pmgr compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230213115741.GA17933@jannau.net>
Date:   Mon, 13 Feb 2023 12:57:41 +0100
From:   Janne Grunau <j@...nau.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Mark Kettenis <kettenis@...nbsd.org>, asahi@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/17] dt-bindings: arm: apple: apple,pmgr: Add
 t8112-pmgr compatible

On 2023-02-13 12:10:36 +0100, Krzysztof Kozlowski wrote:
> On 12/02/2023 16:41, Janne Grunau wrote:
> > The block on Apple M2 SoCs is compatible with the existing driver so
> > just add its per-SoC compatible.
> > 
> > Signed-off-by: Janne Grunau <j@...nau.net>
> > 
> > ---
> > This trivial dt-bindings update should be merged through the asahi-soc
> > tree to ensure validation of the Apple M2 (t8112) devicetrees in this
> > series.
> 
> No, the bindings go via subsystem. Just because you want to validate
> something is not really a reason - you can validate on next. Don't
> create special rules for Asahi... or rather - why Asahi is special than
> everyone else?

We did that 2 or 3 times in the past without commnts that it is not 
desired so I wasn't aware that this would be special handling.

Merging binding and devicetree updates together looks to me like the 
most sensible option since dtbs validation is the only testable 
dependecy of dt binding updates.
Keeping them together ensures the dtbs validate without delaying 
devicetree changes by one kernel release after the dt-bindings change 
was merged.
I suppose it works out most of the time if the merge request is sent 
only if it validates in next. That still depends on the merge order in 
the merge window but -rc1 should be fine.

I'll consider devicetree validation as eventually valid from now on and 
not care too much about it.

Janne