| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Feb 2023 20:46:50 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Tom Rix <trix@...hat.com>, abelvesa@...nel.org,
mturquette@...libre.com, sboyd@...nel.org, shawnguo@...nel.org,
s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
linux-imx@....com
Cc: linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: imx: set imx_clk_gpr_mux_ops storage-class-specifier
to static
On 2/5/2023 11:01 AM, Tom Rix wrote:
> smatch reports
> drivers/clk/imx/clk-gpr-mux.c:73:22: warning: symbol 'imx_clk_gpr_mux_ops' was not declared. Should it be static?
>
> imx_clk_gpr_mux_ops is only used in clk-gpr-mux.c, so it should be static.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
Reviewed-by: Peng Fan <peng.fan@....com>
> ---
> drivers/clk/imx/clk-gpr-mux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-gpr-mux.c b/drivers/clk/imx/clk-gpr-mux.c
> index 47a3e3cdcc82..c8d6090f15d6 100644
> --- a/drivers/clk/imx/clk-gpr-mux.c
> +++ b/drivers/clk/imx/clk-gpr-mux.c
> @@ -70,7 +70,7 @@ static int imx_clk_gpr_mux_determine_rate(struct clk_hw *hw,
> return clk_mux_determine_rate_flags(hw, req, 0);
> }
>
> -const struct clk_ops imx_clk_gpr_mux_ops = {
> +static const struct clk_ops imx_clk_gpr_mux_ops = {
> .get_parent = imx_clk_gpr_mux_get_parent,
> .set_parent = imx_clk_gpr_mux_set_parent,
> .determine_rate = imx_clk_gpr_mux_determine_rate,
Powered by blists - more mailing lists