linux-kernel - Re: [PATCH V3 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed3637e4-7a5a-55be-be49-cdb0ec978752@quicinc.com>
Date:   Mon, 13 Feb 2023 19:48:54 +0530
From:   Devi Priya <quic_devipriy@...cinc.com>
To:     Bjorn Andersson <andersson@...nel.org>
CC:     <agross@...nel.org>, <konrad.dybcio@...aro.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <mturquette@...libre.com>, <sboyd@...nel.org>,
        <linus.walleij@...aro.org>, <catalin.marinas@....com>,
        <will@...nel.org>, <p.zabel@...gutronix.de>, <shawnguo@...nel.org>,
        <arnd@...db.de>, <marcel.ziswiler@...adex.com>,
        <dmitry.baryshkov@...aro.org>, <nfraprado@...labora.com>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <quic_srichara@...cinc.com>, <quic_gokulsri@...cinc.com>,
        <quic_sjaganat@...cinc.com>, <quic_kathirav@...cinc.com>,
        <quic_arajkuma@...cinc.com>, <quic_anusha@...cinc.com>,
        <quic_poovendh@...cinc.com>
Subject: Re: [PATCH V3 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver

Thanks Bjorn for taking time to review the patch

On 2/9/2023 4:44 AM, Bjorn Andersson wrote:
> On Mon, Jan 30, 2023 at 06:25:25PM +0530, devi priya wrote:
>> +static const struct msm_pingroup ipq9574_groups[] = {
>> +	PINGROUP(0, sdc_data, qspi_data, qdss_traceclk_b, _, _, _, _, _, _),
>> +	PINGROUP(1, sdc_data, qspi_data, qdss_tracectl_b, _, _, _, _, _, _),
>> +	PINGROUP(2, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _),
>> +	PINGROUP(3, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _),
>> +	PINGROUP(4, sdc_cmd, qspi_cs, qdss_tracedata_b, _, _, _, _, _, _),
>> +	PINGROUP(5, sdc_clk, qspi_clk, qdss_tracedata_b, _, _, _, _, _,
>> +		 _),
> 
> Please avoid line wrapping these, it just makes it hard to read.
Yes, we have addressed this comment part of V7 series
https://lore.kernel.org/linux-arm-kernel/20230206103337.21000-5-quic_devipriy@quicinc.com/
> 
> [..]
>> +};
>> +
>> +/* Reserving GPIO59 for controlling the QFPROM LDO regulator */
> 
> This seems like a property of the board, please use gpio-reserved-ranges
> in the DT node instead.
As the GPIO is forbidden on SoC IPQ9574,
we have moved it to the pinctrl driver based on the suggestions received
in V1 series
https://lore.kernel.org/linux-arm-kernel/675ed9f7-da31-6206-5089-1db22025ef4b@linaro.org/
> 
> Thanks,
> Bjorn
Best Regards,
Devi Priya