linux-kernel - [GIT PULL] tracing: Make trace_define_field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Feb 2023 10:08:36 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Yafang Shao <laoar.shao@...il.com>
Subject: [GIT PULL] tracing: Make trace_define_field_ext() static


Linus,

tracing: Make trace_define_field_ext() static

Just after the fix to TASK_COMM_LEN not converted to its value in
trace_events was pulled, the kernel test robot reported that the helper
function trace_define_field_ext() added to that change was only used in
the file it was defined in but was not declared static. Make it a local
function.


Please pull the latest trace-v6.2-rc7-2 tree, which can be found at:


  git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace-v6.2-rc7-2

Tag SHA1: 3883ec09ec4e45286f3c09d4a88dbde8b328573c
Head SHA1: 70b5339caf847b8b6097b6dfab0c5a99b40713c8


Steven Rostedt (Google) (1):
      tracing: Make trace_define_field_ext() static

----
 kernel/trace/trace_events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---------------------------
commit 70b5339caf847b8b6097b6dfab0c5a99b40713c8
Author: Steven Rostedt (Google) <rostedt@...dmis.org>
Date:   Sun Feb 12 20:11:42 2023 -0500

    tracing: Make trace_define_field_ext() static
    
    trace_define_field_ext() is not used outside of trace_events.c, it should
    be static.
    
    Link: https://lore.kernel.org/oe-kbuild-all/202302130750.679RaRog-lkp@intel.com/
    
    Fixes: b6c7abd1c28a ("tracing: Fix TASK_COMM_LEN in trace event format file")
    Reported-by: Reported-by: kernel test robot <lkp@...el.com>
    Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 6a4696719297..6a942fa275c7 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -155,7 +155,7 @@ int trace_define_field(struct trace_event_call *call, const char *type,
 }
 EXPORT_SYMBOL_GPL(trace_define_field);
 
-int trace_define_field_ext(struct trace_event_call *call, const char *type,
+static int trace_define_field_ext(struct trace_event_call *call, const char *type,
 		       const char *name, int offset, int size, int is_signed,
 		       int filter_type, int len)
 {