linux-kernel - Re: [syzbot] WARNING: locking bug in umh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+pTx0yFUrMpR8E2@hirez.programming.kicks-ass.net>
Date:   Mon, 13 Feb 2023 16:14:15 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Schspa Shi <schspa@...il.com>, Ingo Molnar <mingo@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        syzkaller-bugs@...glegroups.com,
        syzbot <syzbot+6cd18e123583550cf469@...kaller.appspotmail.com>,
        Hillf Danton <hdanton@...a.com>
Subject: Re: [syzbot] WARNING: locking bug in umh_complete

On Mon, Feb 06, 2023 at 07:51:16AM -0800, Luis Chamberlain wrote:

> I think this seems to be the same issue that Schspa Shi reported / provided a
> fix sugggestion for [0]. This lead me to ask if:
> 
>   a) incorrect usage of completion on stack could be generic and;
>   b) if we should instead have an API helper for that?
> 
> Although he already implemented a suggestion for b) to answer a) we need
> some SmPL constructs yet to be written by Schspa. The reason I asked for
> b) is that if this is a regular pattern it begs for a) as this sort of
> issue could be prevalent in other places. So the status of Schspa's work
> was that he was going to work on the SmPL grammar to check how frequent
> this incorrect patern could be found.
> 
> Please let me know your thoughts as perhaps this issue / discussion
> didn't get on Peter's radar as it was rececently discussed with Schspa
> despite being on Cc.
> 
> [0] https://lore.kernel.org/all/m2pmcoag55.fsf@gmail.com/T/#u

-ETOODAMNMUCHEMAIL :-/

Urgh, esp. :

  https://lore.kernel.org/all/m2pmcoag55.fsf@gmail.com/T/#m9f0105d28fcfe4947a2583cd3d425169c4fe5dfa

is quite insane.