linux-kernel - Re: [PATCH v3 3/4] dmaengine: dw-edma: Add support for native HDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202302132344.oOgPHjYP-lkp@intel.com>
Date:   Mon, 13 Feb 2023 23:20:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Cai Huoqing <cai.huoqing@...ux.dev>,
        Sergey.Semin@...kalelectronics.ru
Cc:     oe-kbuild-all@...ts.linux.dev, Cai huoqing <cai.huoqing@...ux.dev>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Vinod Koul <vkoul@...nel.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH v3 3/4] dmaengine: dw-edma: Add support for native HDMA

Hi Cai,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20230213]
[cannot apply to vkoul-dmaengine/next linus/master v6.2-rc8 v6.2-rc7 v6.2-rc6 v6.2-rc8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Cai-Huoqing/dmaengine-dw-edma-Rename-dw_edma_core_ops-structure-to-dw_edma_plat_ops/20230213-213412
patch link:    https://lore.kernel.org/r/20230213132411.65524-4-cai.huoqing%40linux.dev
patch subject: [PATCH v3 3/4] dmaengine: dw-edma: Add support for native HDMA
config: i386-randconfig-a016-20230213 (https://download.01.org/0day-ci/archive/20230213/202302132344.oOgPHjYP-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/04d89cfa187deda4fa5a7cc947dbb797ce05e72f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Cai-Huoqing/dmaengine-dw-edma-Rename-dw_edma_core_ops-structure-to-dw_edma_plat_ops/20230213-213412
        git checkout 04d89cfa187deda4fa5a7cc947dbb797ce05e72f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302132344.oOgPHjYP-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/dma/dw-edma/dw-hdma-v0-core.c: In function 'dw_hdma_v0_write_ll_data':
>> drivers/dma/dw-edma/dw-hdma-v0-core.c:195:17: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
     195 |                 writeq(sar, &lli->sar.reg);
         |                 ^~~~~~
         |                 writel
   cc1: some warnings being treated as errors


vim +195 drivers/dma/dw-edma/dw-hdma-v0-core.c

   177	
   178	static void dw_hdma_v0_write_ll_data(struct dw_edma_chunk *chunk, int i,
   179					     u32 control, u32 size, u64 sar, u64 dar)
   180	{
   181		ptrdiff_t ofs = i * sizeof(struct dw_hdma_v0_lli);
   182	
   183		if (chunk->chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL) {
   184			struct dw_hdma_v0_lli *lli = chunk->ll_region.vaddr.mem + ofs;
   185	
   186			lli->control = control;
   187			lli->transfer_size = size;
   188			lli->sar.reg = sar;
   189			lli->dar.reg = dar;
   190		} else {
   191			struct dw_hdma_v0_lli __iomem *lli = chunk->ll_region.vaddr.io + ofs;
   192	
   193			writel(control, &lli->control);
   194			writel(size, &lli->transfer_size);
 > 195			writeq(sar, &lli->sar.reg);
   196			writeq(dar, &lli->dar.reg);
   197		}
   198	}
   199	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests