linux-kernel - Re: [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+pWRx2ly/qdFq9k@casper.infradead.org>
Date:   Mon, 13 Feb 2023 15:24:55 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     Jens Axboe <axboe@...nel.dk>, Al Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@...radead.org>, Jan Kara <jack@...e.cz>,
        Jeff Layton <jlayton@...nel.org>,
        David Hildenbrand <david@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Hillf Danton <hdanton@...a.com>, linux-fsdevel@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Christoph Hellwig <hch@....de>,
        John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH 3/4] splice: Use init_sync_kiocb() in
 filemap_splice_read()

On Mon, Feb 13, 2023 at 01:46:18PM +0000, David Howells wrote:
> Use init_sync_kiocb() in filemap_splice_read() rather than open coding it
> and filter out IOCB_NOWAIT since the splice is synchronous.

If the user has asked for NOWAIT and the splice is going to be
synchronous, shouldn't we rather return -EWOULDBLOCK here?  Or
does this not block?

IOW, this either does the wrong thing, or it does something that's
irrelevant.