linux-kernel - Re: [PATCH 2/2] ACPI: x86: Add more systems to quirk list for forcing StorageD3Enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j0GYyrF33=7ginfhYMrNyD=EDUK0RuHHYkKJ2VZAQnsQ@mail.gmail.com>
Date:   Tue, 14 Feb 2023 15:48:44 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     rafael@...nel.org, linux-kernel@...r.kernel.org, dbilios@...io.gr,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 2/2] ACPI: x86: Add more systems to quirk list for forcing StorageD3Enable

On Mon, Feb 13, 2023 at 10:35 PM Mario Limonciello
<mario.limonciello@....com> wrote:
>
> commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1
> for StorageD3Enable") introduced a quirk to allow a system with ambiguous
> use of _ADR 0 to force StorageD3Enable.
>
> It is reported that Vostro 5626 suffers same symptoms. Add this other
> system to the list as well.
>
> Suggested-by: dbilios@...io.gr
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217003
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Can you please combine these two patches into one?

Or at least make the subjects differ?

> ---
>  drivers/acpi/x86/utils.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> index 3409ce6513afa..b1d24718f73d7 100644
> --- a/drivers/acpi/x86/utils.c
> +++ b/drivers/acpi/x86/utils.c
> @@ -214,6 +214,7 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
>                  * but .NVME is needed to get StorageD3Enable node
>                  * https://bugzilla.kernel.org/show_bug.cgi?id=216440
>                  * https://bugzilla.kernel.org/show_bug.cgi?id=216773
> +                * https://bugzilla.kernel.org/show_bug.cgi?id=217003
>                  */
>                 .matches = {
>                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> @@ -232,6 +233,12 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
>                         DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 16 5625"),
>                 }
>         },
> +       {
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 5625"),
> +               }
> +       },
>         {}
>  };
>
> --
> 2.34.1
>