linux-kernel - Re: [PATCH bpf-next 1/2] bpf: use canonical ftrace path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+u1lL49CB86VSuE@google.com>
Date:   Tue, 14 Feb 2023 09:23:48 -0700
From:   Ross Zwisler <zwisler@...gle.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     Ross Zwisler <zwisler@...omium.org>, linux-kernel@...r.kernel.org,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Hao Luo <haoluo@...gle.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Jiri Olsa <jolsa@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Leon Romanovsky <leon@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-rdma@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
        linux-trace-kernel@...r.kernel.org,
        "Michael S . Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH bpf-next 1/2] bpf: use canonical ftrace path

On Mon, Feb 13, 2023 at 06:57:16PM -0800, Stanislav Fomichev wrote:
> On 02/13, Ross Zwisler wrote:
> > The canonical location for the tracefs filesystem is at
> > /sys/kernel/tracing.
> 
> > But, from Documentation/trace/ftrace.rst:
> 
> >    Before 4.1, all ftrace tracing control files were within the debugfs
> >    file system, which is typically located at /sys/kernel/debug/tracing.
> >    For backward compatibility, when mounting the debugfs file system,
> >    the tracefs file system will be automatically mounted at:
> 
> >    /sys/kernel/debug/tracing
> 
> > Many comments and samples in the bpf code still refer to this older
> > debugfs path, so let's update them to avoid confusion.  There are a few
> > spots where the bpf code explicitly checks both tracefs and debugfs
> > (tools/bpf/bpftool/tracelog.c and tools/lib/api/fs/fs.c) and I've left
> > those alone so that the tools can continue to work with both paths.
> 
> Doesn't seem to apply cleanly to bpf-next?
> 
> https://github.com/kernel-patches/bpf/pull/4584

Oh, apologies, I was using Linus's master branch as my baseline.
I'll send out a v2.