linux-kernel - Re: [PATCH v3] sched/psi: fix use-after-free in ep_remove_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpFpTGbPnJBh-MT3nat0t=HVr2ZWLELDAYtQ+TYhjg6XHg@mail.gmail.com>
Date:   Tue, 14 Feb 2023 11:13:45 -0800
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     Munehisa Kamata <kamatam@...zon.com>, hannes@...xchg.org,
        hdanton@...a.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        mengcc@...zon.com, stable@...r.kernel.org
Subject: Re: [PATCH v3] sched/psi: fix use-after-free in ep_remove_wait_queue()

On Tue, Feb 14, 2023 at 10:55 AM Eric Biggers <ebiggers@...nel.org> wrote:
>
> On Tue, Feb 14, 2023 at 10:13:35AM -0800, Munehisa Kamata wrote:
> > Using wake_up_pollfree() here might be less than ideal, but it also is not
> > fully contradicting the comment at commit 42288cb44c4b ("wait: add
> > wake_up_pollfree()") since the waitqueue's lifetime is not tied to file's
> > one and can be considered as another special case.
>
> If that comment is outdated now, then please update the comment too.  We can do
> better than "not fully contradicting".

Agree. I don't see it contradicting that comment.

>
> - Eric