linux-kernel - Re: [REGRESSION] rtc: imx-sc: remove .read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+vofPf0YVp5Ay65@mail.local>
Date:   Tue, 14 Feb 2023 21:01:00 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Marcel Ziswiler <marcel.ziswiler@...adex.com>
Cc:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "linux-imx@....com" <linux-imx@....com>
Subject: Re: [REGRESSION] rtc: imx-sc: remove .read_alarm

Hello,

On 08/02/2023 15:06:28+0000, Marcel Ziswiler wrote:
> Hi Alexandre
> 
> Were you aware that this breaks the sysfs use case? E.g. before we were able to suspend and resume 10 seconds
> later as follows:
> 
> echo +10 > /sys/class/rtc/rtc1/wakealarm; echo mem > /sys/power/state
> 
> Since the removal of .read_alarm in commit 7942121b8ca0 ("rtc: imx-sc: remove .read_alarm") this no longer
> seems to work.
> 
> This seems like a regression or is this not supposed to work?

This seems like a regression and I think it was reported a while ago and
then again just after you. I believe there is something to do that is
smarter than reverting the patch, I need to check.

Regards

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com