linux-kernel - Re: [RFC PATCH] dt-bindings: dma: apple,sio: Add schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9938921C-29ED-4253-9F9D-4BA7432448F3@cutebit.org>
Date:   Tue, 14 Feb 2023 21:02:33 +0100
From:   Martin Povišer <povik+lin@...ebit.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Hector Martin <marcan@...can.st>,
        Sven Peter <sven@...npeter.dev>, Janne Grunau <j@...nau.net>,
        dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, asahi@...ts.linux.dev
Subject: Re: [RFC PATCH] dt-bindings: dma: apple,sio: Add schema

Thanks for the review!

> On 14. 2. 2023, at 20:25, Rob Herring <robh@...nel.org> wrote:
> 
> On Tue, Feb 14, 2023 at 03:10:53PM +0100, Martin Povišer wrote:
>> Describe the SIO coprocessor which serves as pretend DMA controller on
>> recent Apple platforms.
>> 
>> Signed-off-by: Martin Povišer <povik+lin@...ebit.org>
>> ---
>> 
>> Since the schema mentions a loader preparing the binding appropriately,
>> here's a PR with the relevant (WIP) loader code, if anyone wants to look:
>> https://github.com/AsahiLinux/m1n1/pull/286
>> 
>> .../devicetree/bindings/dma/apple,sio.yaml    | 129 ++++++++++++++++++
>> 1 file changed, 129 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/dma/apple,sio.yaml
>> 
>> diff --git a/Documentation/devicetree/bindings/dma/apple,sio.yaml b/Documentation/devicetree/bindings/dma/apple,sio.yaml
>> new file mode 100644
>> index 000000000000..a76cc8265e76
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/dma/apple,sio.yaml

(...)

>> +  memory-region:
>> +    description:
>> +      A number of references to reserved memory regions among which are the DATA/TEXT
>> +      sections of coprocessor executable firmware and also auxiliary firmware data
>> +      describing the available DMA-enabled peripherals
> 
> Can you define some range of number of entries.

I think I can provide a reliable lower bound (at least one segment with
DATA/TEXT and one segment with auxiliary data), and a conservative upper bound
(separate DATA/TEXT and no more than 6 segments of auxiliary data if each kind
of data has a segment of its own). I will work it in into the next version.

Martin