linux-kernel - Re: [PATCH v2 3/3] iommu: Remove ioasid infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230214133352.1f69b624@jacob-builder>
Date:   Tue, 14 Feb 2023 13:33:52 -0800
From:   Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     Jean-Philippe Brucker <jean-philippe@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>, iommu@...ts.linux.dev,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>,
        Jean-Philippe Brucker <jean-philippe@...aro.com>,
        Robin Murphy <robin.murphy@....com>,
        Will Deacon <will@...nel.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Raj Ashok <ashok.raj@...el.com>,
        "Tian, Kevin" <kevin.tian@...el.com>, Yi Liu <yi.l.liu@...el.com>,
        jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v2 3/3] iommu: Remove ioasid infrastructure

Hi Jason,

On Tue, 14 Feb 2023 13:57:29 -0400, Jason Gunthorpe <jgg@...dia.com> wrote:

> On Tue, Feb 14, 2023 at 09:31:07AM -0800, Jacob Pan wrote:
> > Hi Jason,
> > 
> > On Tue, 14 Feb 2023 09:06:18 -0400, Jason Gunthorpe <jgg@...dia.com>
> > wrote: 
> > > On Tue, Feb 14, 2023 at 09:32:33AM +0000, Jean-Philippe Brucker
> > > wrote:  
> > > > > diff --git a/include/uapi/linux/iommu.h
> > > > > b/include/uapi/linux/iommu.h index 65d8b0234f69..a95f07f0c98c
> > > > > 100644 --- a/include/uapi/linux/iommu.h
> > > > > +++ b/include/uapi/linux/iommu.h
> > > > > @@ -157,5 +157,6 @@ struct iommu_page_response {
> > > > >  	__u32	grpid;
> > > > >  	__u32	code;
> > > > >  };
> > > > > +#define IOMMU_PASID_INVALID	(-1U)    
> > > > 
> > > > Why change UAPI?    
> > > 
> > > There is no uapi, this whole file needs to be deleted too
> > >   
> > ok. another clean up.
> > 
> > As I also replied to Jean, I ran into a circular #include problem if
> > mm.h #include iommu.h, I guess I could also create another header, e.g.
> > iommu_defs.h to avoid it. any other suggestions?  
> 
> Given this header is not used, just delete things from it to resolve
> the problem?
no, sorry i didn't make it clear. I meant if we do #include <linux/iommu.h>
in sched/mm.h, then I got circular include problem.

The problem is not with include/uapi/linux/iommu.h

I could fix it by adding another header include/linux/iommu_defs.h for
#define IOMMU_PASID_INVALID	(-1U) 
But it feels like an overkill.

Thanks,

Jacob