linux-kernel - RE: [PATCH v2 1/3] media: pci: intel: ivsc: Add CSI submodule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB4316408448DC0A07D347ED188DA29@DM6PR11MB4316.namprd11.prod.outlook.com>
Date:   Tue, 14 Feb 2023 06:25:35 +0000
From:   "Wu, Wentong" <wentong.wu@...el.com>
To:     Hillf Danton <hdanton@...a.com>
CC:     "mchehab@...nel.org" <mchehab@...nel.org>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "Wang, Zhifeng" <zhifeng.wang@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/3] media: pci: intel: ivsc: Add CSI submodule


Hi Hillf Danton,

Thanks for your review

> -----Original Message-----
> From: Hillf Danton <hdanton@...a.com>
> Sent: Monday, February 13, 2023 11:42 AM
> 
> On Mon, 13 Feb 2023 10:23:45 +0800 Wentong Wu <wentong.wu@...el.com>
> > +
> > +/* send a command to firmware and mutex must be held by caller */
> > +static int mei_csi_send(u8 *buf, size_t len) {
> > +	struct csi_cmd *cmd = (struct csi_cmd *)buf;
> > +	int ret;
> > +
> > +	reinit_completion(&csi->cmd_completion);
> 
> Could you specify why reinit is needed here?

This allows new command(e.g. 'get status' command to check current firmware status) to be downloaded to firmware for debugging purpose in case no response for current command though I have never saw this happen.  

> What is hurt without it?

No hurt for current implementation. I can remove it.

> 
> Same question for the reinit in 2/3.

same ack for 2/3

> 
> > +
> > +	ret = mei_cldev_send(csi->cldev, buf, len);
> > +	if (ret < 0)
> > +		goto out;
> > +
> > +	ret = wait_for_completion_killable_timeout(&csi->cmd_completion,
> > +						   CSI_CMD_TIMEOUT);
> > +	if (ret < 0) {
> > +		goto out;
> > +	} else if (!ret) {
> > +		ret = -ETIMEDOUT;
> > +		goto out;
> > +	}