linux-kernel - Re: [PATCH v2 04/21] KVM: x86: Generate set of VMX feature MSRs using first/last definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ede401b-292b-0434-d1b4-bb387c59e0ac@intel.com>
Date:   Tue, 14 Feb 2023 14:36:46 +0800
From:   Xiaoyao Li <xiaoyao.li@...el.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Like Xu <like.xu.linux@...il.com>
Subject: Re: [PATCH v2 04/21] KVM: x86: Generate set of VMX feature MSRs using
 first/last definitions

On 2/10/2023 8:31 AM, Sean Christopherson wrote:
> Add VMX MSRs to the runtime list of feature MSRs by iterating over the
> range of emulated MSRs instead of manually defining each MSR in the "all"
> list.  Using the range definition reduces the cost of emulating a new VMX
> MSR, e.g. prevents forgetting to add an MSR to the list.
> 
> Extracting the VMX MSRs from the "all" list, which is a compile-time
> constant, also shrinks the list to the point where the compiler can
> heavily optimize code that iterates over the list.
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

Reviewed-by: Xiaoyao Li <xiaoyao.li@...el.com>