linux-kernel - RE: [PATCH v5 char-misc-next] misc: microchip: pci1xxxx: Add OTP/EEPROM driver for the pci1xxxx switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR11MB5958E626F5FA9BAB2B9FA2F39BA29@PH7PR11MB5958.namprd11.prod.outlook.com>
Date:   Tue, 14 Feb 2023 06:52:56 +0000
From:   <Tharunkumar.Pasumarthi@...rochip.com>
To:     <christophe.jaillet@...adoo.fr>, <linux-kernel@...r.kernel.org>
CC:     <linux-gpio@...r.kernel.org>, <gregkh@...uxfoundation.org>,
        <arnd@...db.de>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v5 char-misc-next] misc: microchip: pci1xxxx: Add
 OTP/EEPROM driver for the pci1xxxx switch

> From: Tharunkumar Pasumarthi - I67821
> Sent: Tuesday, February 14, 2023 12:08 PM
> To: Christophe JAILLET <christophe.jaillet@...adoo.fr>; linux-
> kernel@...r.kernel.org
> Hi Christophe,
> Thanks for your comments.
> 
> In the earlier version of patch, auxiliary_driver_unregister was done before
> unregister_blkdev.
> But Greg suggested to change it this way - "You need to unregister your block
> device _BEFORE_ the aux device goes away underneath it". Hence followed
> this order.

Since block device is a child of the aux device, it makes sense to remove block device before removing the aux_device.
So that unwinding of the device stack is done in the reverse order of creation.

Thanks,
Tharun Kumar P