linux-kernel - Re: [PATCH] module: fix MIPS module_layout -> module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59c0ba61-c5d6-b74f-0fbd-844b08d13e5d@linaro.org>
Date:   Tue, 14 Feb 2023 08:22:02 +0100
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Song Liu <song@...nel.org>, Luis Chamberlain <mcgrof@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH] module: fix MIPS module_layout -> module_memory

Hi Randy,

On 14/2/23 01:54, Randy Dunlap wrote:
> Correct the struct's field/member name from mod_mem to mem.
> 
> Fixes this build error:
> ../arch/mips/kernel/vpe.c: In function 'vpe_elfload':
> ../arch/mips/kernel/vpe.c:643:41: error: 'struct module' has no member named 'mod_mem'
>    643 |         v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
> 
> Fixes: 2ece476a2346 ("module: replace module_layout with module_memory")

On which tree is your patch based?

fatal: ambiguous argument '2ece476a2346': unknown revision or path not 
in the working tree.

> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Song Liu <song@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Cc: linux-mips@...r.kernel.org
> ---
> Has this already been fixed?
> 
>   arch/mips/kernel/vpe.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -- a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c
> --- a/arch/mips/kernel/vpe.c
> +++ b/arch/mips/kernel/vpe.c
> @@ -640,7 +640,7 @@ static int vpe_elfload(struct vpe *v)
>   		layout_sections(&mod, hdr, sechdrs, secstrings);
>   	}
>   
> -	v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
> +	v->load_addr = alloc_progmem(mod.mem[MOD_TEXT].size);
>   	if (!v->load_addr)
>   		return -ENOMEM;
>