linux-kernel - Re: [PATCH -next] dmaengine: xilinx: xdma: Fix some kernel-doc comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2023 10:19:09 +0100
From:   Peter Korsgaard <peter@...sgaard.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     vkoul@...nel.org, michal.simek@...inx.com, lizhi.hou@....com,
        brian.xu@....com, raj.kumar.rampelli@....com,
        dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] dmaengine: xilinx: xdma: Fix some kernel-doc
 comments

>>>>> "Yang" == Yang Li <yang.lee@...ux.alibaba.com> writes:

 > Make the description of @xdma_chan to @xchan to silence the warnings:
 > drivers/dma/xilinx/xdma.c:283: warning: Function parameter or member 'xchan' not described in 'xdma_xfer_start'
 > drivers/dma/xilinx/xdma.c:283: warning: Excess function parameter 'xdma_chan' description in 'xdma_xfer_start'

 > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
 > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4051
 > Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Acked-by: Peter Korsgaard <peter@...sgaard.com>

> ---
 >  drivers/dma/xilinx/xdma.c | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
 > index 462109c61653..93ee298d52b8 100644
 > --- a/drivers/dma/xilinx/xdma.c
 > +++ b/drivers/dma/xilinx/xdma.c
 > @@ -277,7 +277,7 @@ xdma_alloc_desc(struct xdma_chan *chan, u32 desc_num)
 
 >  /**
 >   * xdma_xfer_start - Start DMA transfer
 > - * @xdma_chan: DMA channel pointer
 > + * @xchan: DMA channel pointer
 >   */
 >  static int xdma_xfer_start(struct xdma_chan *xchan)
 >  {
 > -- 

 > 2.20.1.7.g153144c


-- 
Bye, Peter Korsgaard