linux-kernel - Re: [PATCH] mmc: sdhci-brcmstb: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2023 13:18:21 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     ye.xingchen@....com.cn
Cc:     kdasu.kdev@...il.com, alcooperx@...il.com,
        bcm-kernel-feedback-list@...adcom.com, adrian.hunter@...el.com,
        f.fainelli@...il.com, linux-mmc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci-brcmstb: Use devm_platform_get_and_ioremap_resource()

On Fri, 10 Feb 2023 at 09:28, <ye.xingchen@....com.cn> wrote:
>
> From: Ye Xingchen <ye.xingchen@....com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-brcmstb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index 0a19b7af1d41..4c22337199cf 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -255,7 +255,6 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
>         struct sdhci_brcmstb_priv *priv;
>         u32 actual_clock_mhz;
>         struct sdhci_host *host;
> -       struct resource *iomem;
>         struct clk *clk;
>         struct clk *base_clk = NULL;
>         int res;
> @@ -291,8 +290,7 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
>         }
>
>         /* Map in the non-standard CFG registers */
> -       iomem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -       priv->cfg_regs = devm_ioremap_resource(&pdev->dev, iomem);
> +       priv->cfg_regs = devm_platform_get_and_ioremap_resource(pdev, 1, NULL);
>         if (IS_ERR(priv->cfg_regs)) {
>                 res = PTR_ERR(priv->cfg_regs);
>                 goto err;
> --
> 2.25.1