linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2023 18:04:22 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Bjorn Andersson <andersson@...nel.org>,
        Alex Elder <elder@...aro.org>
CC:     Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info
 region

+@...x,

Please comment.

-Mukesh

On 2/7/2023 2:34 AM, Bjorn Andersson wrote:
> On Mon, Feb 06, 2023 at 08:06:13PM +0530, Mukesh Ojha wrote:
>>
>>
>> On 2/4/2023 3:07 AM, Konrad Dybcio wrote:
>>>
>>>
>>> On 3.02.2023 18:04, Mukesh Ojha wrote:
>>>> Add a simple-mfd representing IMEM on SM8450 and define the PIL
>>>> relocation info region, so that post mortem tools will be able
>>>> to locate the loaded remoteprocs.
>>>>
>>>> Signed-off-by: Mukesh Ojha <quic_mojha@...cinc.com>
>>>> ---
>>>   From XBL:
>>>
>>> 0x14680000, 0x0002A000, "IMEM Base"
>>>
>>> Is there anything in that wider address range that would interest
>>> us? I recall Alex once dug into that when diving into IPA, but
>>> I can not recall the conclusion..
>> Spec-wise, yes IPA do own these 0x146A8000 - 0x146AA000 .
>> But, not sure what they use it for.
>>
> 
> The DT should not reflect the organization structure. Let's see if Alex
> have any input on this.
> 
> Thanks,
> Bjorn
> 
>> -Mukesh
>>>
>>> Konrad
>>>>    arch/arm64/boot/dts/qcom/sm8450.dtsi | 15 +++++++++++++++
>>>>    1 file changed, 15 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> index 5704750..474ea1b 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> @@ -3536,6 +3536,21 @@
>>>>    			};
>>>>    		};
>>>> +		sram@...aa000 {
>>>> +			compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
>>>> +			reg = <0 0x146aa000 0 0x1000>;
>>>> +
>>>> +			#address-cells = <1>;
>>>> +			#size-cells = <1>;
>>>> +
>>>> +			ranges = <0 0 0x146aa000 0x1000>;
>>>> +
>>>> +			pil-reloc@94c {
>>>> +				compatible = "qcom,pil-reloc-info";
>>>> +				reg = <0x94c 0xc8>;
>>>> +			};
>>>> +		};
>>>> +
>>>>    		apps_rsc: rsc@...00000 {
>>>>    			label = "apps_rsc";
>>>>    			compatible = "qcom,rpmh-rsc";