linux-kernel - RE: [PATCH v2 1/3] media: pci: intel: ivsc: Add CSI submodule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB43169E925577B4054D664FA28DA29@DM6PR11MB4316.namprd11.prod.outlook.com>
Date:   Tue, 14 Feb 2023 12:40:12 +0000
From:   "Wu, Wentong" <wentong.wu@...el.com>
To:     Hillf Danton <hdanton@...a.com>
CC:     "mchehab@...nel.org" <mchehab@...nel.org>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "Wang, Zhifeng" <zhifeng.wang@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/3] media: pci: intel: ivsc: Add CSI submodule


> -----Original Message-----
> From: Hillf Danton <hdanton@...a.com>
> Sent: Tuesday, February 14, 2023 4:36 PM
> 
> On Tue, 14 Feb 2023 06:25:35 +0000 Wentong Wu <wentong.wu@...el.com>
> >
> > This allows new command(e.g. 'get status' command to check current
> > firmware=
> >  status) to be downloaded to firmware for debugging purpose in case no
> > resp= onse for current command though I have never saw this happen.
> > =20
> 
> Thanks for your specification.
> 
> Another question, is it likely for the wakeup to come after reinit because of for
> instance timeout on the waiter side?

Thanks, first I want to clarify why we have timeout here, in case firmware stuck somehow or IVSC device is removed suddenly, calling thread can't be wakeup if wait forever here.

And firmware gets high priority to handle command and response, also there is timeout mechanism inside firmware, I think there will be some problem with firmware if driver gets command response after 5s which will be captured by driver code(if (csi->cmd_response.cmd_id != cmd->cmd_id)) but I have never saw this happen.

BR,
Wentong