linux-kernel - Re: [PATCH v2] fixed typos on selftests/bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c810373e-9fa5-9b2f-9425-af557c6dcbae@linux.dev>
Date:   Wed, 15 Feb 2023 10:21:44 -0800
From:   Martin KaFai Lau <martin.lau@...ux.dev>
To:     Taichi Nishimura <awkrail01@...il.com>
Cc:     andrii@...nel.org, ast@...nel.org, daniel@...earbox.net,
        davem@...emloft.net, deso@...teo.net, haoluo@...gle.com,
        hawk@...nel.org, joannelkoong@...il.com, john.fastabend@...il.com,
        jolsa@...nel.org, kpsingh@...nel.org, kuba@...nel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        llvm@...ts.linux.dev, mykolal@...com, nathan@...nel.org,
        ndesaulniers@...gle.com, netdev@...r.kernel.org, sdf@...gle.com,
        shuah@...nel.org, song@...nel.org, trix@...hat.com, yhs@...com,
        ytcoode@...il.com, rdunlap@...radead.org
Subject: Re: [PATCH v2] fixed typos on selftests/bpf

On 2/14/23 7:21 PM, Taichi Nishimura wrote:
> Hi Randy,
> 
> Thank you for your reviewing.
> I fixed costant and it's to constant and its, respectively.
> 
> Best regards,
> Taichi Nishimura
> 
> Signed-off-by: Taichi Nishimura <awkrail01@...il.com>
> ---
>   tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> index a8ba39848bbf..66b304982245 100644
> --- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> +++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> @@ -610,8 +610,8 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
>    *
>    *    fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
>    *
> - * clang will substitute a costant for sizeof, which allows the verifier
> - * to track it's value. Based on this, it can figure out the constant
> + * clang will substitute a constant for sizeof, which allows the verifier
> + * to track its value. Based on this, it can figure out the constant

This does not apply. Ensure the diff is generated by git, and against the 
bpf-next tree. Please include everything in v1 also, resubmit and tag for 
bpf-next in the subject.