linux-kernel - Re: [PATCH v2 1/2] dt-bindings: rtc: nxp,pcf8563: move pcf85263/pcf85363 to a dedicated binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e4b15b1-30f6-ca4e-1355-3c4d36b79541@linaro.org>
Date:   Wed, 15 Feb 2023 21:22:34 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Javier Carrasco <javier.carrasco@...fvision.net>,
        linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Michael Riesch <michael.riesch@...fvision.net>
Subject: Re: [PATCH v2 1/2] dt-bindings: rtc: nxp,pcf8563: move
 pcf85263/pcf85363 to a dedicated binding

On 15/02/2023 09:18, Javier Carrasco wrote:
> These Real Time Clocks are managed by the rtc-pcf85363 device driver,
> which now supports the quartz-load-femtofarads property.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco@...fvision.net>
> ---
> v2:
>   - create new bindings instead of adding conditional properties to an
>     existing one.
> 
>  .../devicetree/bindings/rtc/nxp,pcf85363.yaml | 60 +++++++++++++++++++
>  .../devicetree/bindings/rtc/nxp,pcf8563.yaml  |  2 -
>  2 files changed, 60 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf85363.yaml
> 
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85363.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85363.yaml
> new file mode 100644
> index 000000000000..52aa3e2091e9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85363.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/nxp,pcf85363.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Philips PCF85263/PCF85363 Real Time Clock
> +
> +maintainers:
> +  - Alexandre Belloni <alexandre.belloni@...tlin.com>
> +
> +allOf:
> +  - $ref: rtc.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nxp,pcf85263
> +      - nxp,pcf85363
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#clock-cells":
> +    const: 0
> +
> +  clock-output-names:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  quartz-load-femtofarads:
> +    description:
> +      The capacitive load of the quartz(x-tal).
> +    enum: [6000, 7000, 12500]
> +    default: 7000
> +
> +  start-year: true
> +  wakeup-source: true

You could drop these two and use "unevaluatedProperties: false" instead
of additionalProp - less coding and binding already will be prepared for
any new RTC common properties. But it is fine for me as is.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof