linux-kernel - Re: [PATCH] mm/uffd: Fix comment in handling pte markers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45e0bb2a-c03c-e5fd-aa77-c2e3d079570c@redhat.com>
Date:   Wed, 15 Feb 2023 21:59:30 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Peter Xu <peterx@...hat.com>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Cc:     Axel Rasmussen <axelrasmussen@...gle.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Nadav Amit <nadav.amit@...il.com>
Subject: Re: [PATCH] mm/uffd: Fix comment in handling pte markers

On 15.02.23 21:58, Peter Xu wrote:
> The comment is obsolete after f369b07c8614 ("mm/uffd: reset write
> protection when unregister with wp-mode", 2022-08-20).  Remove it.
> 
> Signed-off-by: Peter Xu <peterx@...hat.com>
> ---
>   mm/memory.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 7a04a1130ec1..f456f3b5049c 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3627,9 +3627,7 @@ static vm_fault_t pte_marker_handle_uffd_wp(struct vm_fault *vmf)
>   {
>   	/*
>   	 * Just in case there're leftover special ptes even after the region
> -	 * got unregistered - we can simply clear them.  We can also do that
> -	 * proactively when e.g. when we do UFFDIO_UNREGISTER upon some uffd-wp
> -	 * ranges, but it should be more efficient to be done lazily here.
> +	 * got unregistered - we can simply clear them.
>   	 */
>   	if (unlikely(!userfaultfd_wp(vmf->vma) || vma_is_anonymous(vmf->vma)))
>   		return pte_marker_clear(vmf);

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb