linux-kernel - Re: [PATCH] drm/amd/display: only warn once in dce110_edp_wait_for_hpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0934601-3a7c-dcb5-8d23-81a3cdfc2c4d@amd.com>
Date:   Wed, 15 Feb 2023 16:34:48 -0500
From:   Harry Wentland <harry.wentland@....com>
To:     Hamza Mahfooz <hamza.mahfooz@....com>,
        amd-gfx@...ts.freedesktop.org
Cc:     Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Wenjing Liu <wenjing.liu@....com>, Jun Lei <Jun.Lei@....com>,
        Charlene Liu <Charlene.Liu@....com>,
        Alvin Lee <Alvin.Lee2@....com>,
        "Nagulendran, Iswara" <Iswara.Nagulendran@....com>,
        Tony Tascioglu <tony.tascioglu@....com>,
        zhikzhai <zhikai.zhai@....com>,
        Wesley Chalmers <Wesley.Chalmers@....com>,
        "Leung, Martin" <Martin.Leung@....com>,
        Mario Limonciello <mario.limonciello@....com>,
        "Leo (Hanghong) Ma" <hanghong.ma@....com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: only warn once in
 dce110_edp_wait_for_hpd_ready()



On 2/14/23 16:12, Hamza Mahfooz wrote:
> Since, hot plugging eDP displays isn't supported, it is sufficient for
> us to warn about the lack of a connected display once. So, use ASSERT()
> in dce110_edp_wait_for_hpd_ready() instead of DC_LOG_WARNING().
> 
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>   drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index fb3fd5b7c78b..0d4d3d586166 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -779,10 +779,8 @@ void dce110_edp_wait_for_hpd_ready(
>   
>   	dal_gpio_destroy_irq(&hpd);
>   
> -	if (false == edp_hpd_high) {
> -		DC_LOG_WARNING(
> -				"%s: wait timed out!\n", __func__);
> -	}
> +	/* ensure that the panel is detected */
> +	ASSERT(edp_hpd_high >   }
>   
>   void dce110_edp_power_control(