linux-kernel - Re: [PATCH stable v5.15.y 1/1] crypto: add __init/_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <281CF1A3-C16D-4598-B741-B1128DA97B5B@oracle.com>
Date:   Wed, 15 Feb 2023 23:10:14 +0000
From:   Saeed Mirzamohammadi <saeed.mirzamohammadi@...cle.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "# v4 . 16+" <stable@...r.kernel.org>,
        Xiu Jianfeng <xiujianfeng@...wei.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Dan Williams <dan.j.williams@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH stable v5.15.y 1/1] crypto: add __init/__exit annotations
 to init/exit funcs

Hi,

> On Feb 14, 2023, at 10:55 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> On Tue, Feb 14, 2023 at 11:53:00AM -0800, Saeed Mirzamohammadi wrote:
>> From: Xiu Jianfeng <xiujianfeng@...wei.com>
>> 
>> Add missing __init/__exit annotations to init/exit funcs.
>> 
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
>> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
>> (cherry picked from commit 33837be33367172d66d1f2bd6964cc41448e6e7c)
>> Cc: stable@...r.kernel.org # 5.15+
>> Signed-off-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@...cle.com>
>> ---
>> crypto/async_tx/raid6test.c | 4 ++--
>> crypto/curve25519-generic.c | 4 ++--
>> crypto/dh.c                 | 4 ++--
>> crypto/ecdh.c               | 4 ++--
>> crypto/ecdsa.c              | 4 ++--
>> crypto/rsa.c                | 4 ++--
>> crypto/sm2.c                | 4 ++--
>> 7 files changed, 14 insertions(+), 14 deletions(-)
> 
> What bug/problem does this resolve?  Why is this needed in stable
> kernels?

I don’t have any specific bug to discuss for this fix. It would help freeing up some memory after initialization for these crypto modules since the init function is only called once but not addressing any major issue. Feel free to disregard if this is trivial for stable.

Thanks,
Saeed