linux-kernel - Re: [PATCH] firmware: turris-mox-rwtm: Fix an error handling path in mox_get_board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3c53024-2830-7bad-9d25-74b0070d5a0a@wanadoo.fr>
Date:   Wed, 15 Feb 2023 10:21:50 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Marek Behún <kabel@...nel.org>,
        Arnd Bergmann <arnd@...db.de>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] firmware: turris-mox-rwtm: Fix an error handling path in
 mox_get_board_info()

Le 15/02/2023 à 10:20, Christophe JAILLET a écrit :
> wait_for_completion_timeout() returns 0 if timed out, and positive (at
> least 1, or number of jiffies left till timeout) if completed.
> 
> In case of timeout, return -ETIMEDOUT.
> 
> Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only.
> ---
>   drivers/firmware/turris-mox-rwtm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
> index 6ea5789a89e2..577e87e1c6ee 100644
> --- a/drivers/firmware/turris-mox-rwtm.c
> +++ b/drivers/firmware/turris-mox-rwtm.c
> @@ -200,8 +200,8 @@ static int mox_get_board_info(struct mox_rwtm *rwtm)
>   		return ret;
>   
>   	ret = wait_for_completion_timeout(&rwtm->cmd_done, HZ / 2);
> -	if (ret < 0)
> -		return ret;
> +	if (ret == 0)
> +		return -ETIMEDOUT;
>   
>   	ret = mox_get_status(MBOX_CMD_BOARD_INFO, reply->retval);
>   	if (ret == -ENODATA) {

NACK, some other need to be fixed in the same file.
I'll send a V2.

CJ