linux-kernel - Re: [PATCH 5.10 88/91] arm64/kexec: Test page size support with new TGRAN range values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1daca8f-46d5-d5b0-8152-23b172d5e63a@huawei.com>
Date:   Wed, 15 Feb 2023 18:58:13 +0800
From:   heyuqiang <heyuqiang1@...wei.com>
To:     <gregkh@...uxfoundation.org>, <anshuman.khandual@....com>,
        <catalin.marinas@....com>, <james.morse@....com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <patches@...ts.linux.dev>,
        <stable@...r.kernel.org>, <will@...nel.org>, <yuzenghui@...wei.com>
CC:     <nixiaoming@...wei.com>, <lijiahuan5@...wei.com>
Subject: Re: [PATCH 5.10 88/91] arm64/kexec: Test page size support with new
 TGRAN range values

There is an error

tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git 
master
head: c911f03f8d444e623724fddd82b07a7e1af42338
commit: d5924531dd8ad012ad13eb4d6a5e120c3dadfc05 arm64/kexec: Test page 
size support with new TGRAN range values
# 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d5924531dd8ad012ad13eb4d6a5e120c3dadfc05

When I compile the ko file, I add [-Werror=type-limits] compilation 
options, an error is reported during compilation.

The log is as follows:

./arch/arm64/include/asm/cpufeature.h: In function 
‘system_supports_4kb_granule’:
./arch/arm64/include/asm/cpufeature.h:653:14: error:
comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
return (val >= ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN) &&
^~
./arch/arm64/include/asm/cpufeature.h: In function 
‘system_supports_64kb_granule’:
./arch/arm64/include/asm/cpufeature.h:666:14: error:
comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
return (val >= ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN) &&
^~

"val" variable type is "u32"
"#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN 0x0"
"#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN 0x0"
comparison of val >= 0 is always true.

If you fix the issue, kindly add following tag where applicable
Reported-by: heyuqiang <heyuqiang1@...wei.com>

Thanks