linux-kernel - Re: [PATCH v2 5/5] pinctrl: at91: Utilise temporary variable for struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+zgPjDruv4cIqDd@smile.fi.intel.com>
Date:   Wed, 15 Feb 2023 15:38:06 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Claudiu.Beznea@...rochip.com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Ludovic.Desroches@...rochip.com,
        linus.walleij@...aro.org, Nicolas.Ferre@...rochip.com,
        alexandre.belloni@...tlin.com
Subject: Re: [PATCH v2 5/5] pinctrl: at91: Utilise temporary variable for
 struct device

On Tue, Feb 14, 2023 at 11:11:58AM +0000, Claudiu.Beznea@...rochip.com wrote:
> On 13.02.2023 17:45, Andy Shevchenko wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > We have a temporary variable to keep pointer to struct device.
> > Utilise it inside the ->probe() implementation.
> 
> Apart from this the patch also removes some { } and does some alignments.
> For clarity some of these might go better in a different patch.

I was under impression that checkpatch will complain about it, but it appears
that it does not. I will issue a new version with this updated.

Thanks for your reviews and testing!

-- 
With Best Regards,
Andy Shevchenko