linux-kernel - Re: [PATCH] reset: ath79: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11f16ccda4f3809caa5b43a955472a7c6e83a8f1.camel@pengutronix.de>
Date:   Wed, 15 Feb 2023 17:24:40 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     ye.xingchen@....com.cn
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: ath79: Use
 devm_platform_get_and_ioremap_resource()

On Mi, 2023-02-15 at 17:05 +0800, ye.xingchen@....com.cn wrote:
> From: Ye Xingchen <ye.xingchen@....com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>
>
> ---
>  drivers/reset/reset-ath79.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/reset/reset-ath79.c b/drivers/reset/reset-ath79.c
> index e48d8fcb3133..801a65db2e15 100644
> --- a/drivers/reset/reset-ath79.c
> +++ b/drivers/reset/reset-ath79.c
> @@ -86,7 +86,6 @@ static int ath79_reset_restart_handler(struct notifier_block *nb,
>  static int ath79_reset_probe(struct platform_device *pdev)
>  {
>  	struct ath79_reset *ath79_reset;
> -	struct resource *res;
>  	int err;
> 
>  	ath79_reset = devm_kzalloc(&pdev->dev,
> @@ -96,8 +95,7 @@ static int ath79_reset_probe(struct platform_device *pdev)
> 
>  	platform_set_drvdata(pdev, ath79_reset);
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	ath79_reset->base = devm_ioremap_resource(&pdev->dev, res);
> +	ath79_reset->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);


Thank you for the patches. Since the resource not used, it seems to me
that devm_platform_ioremap_resource() would be a better fit.

regards
Philipp