linux-kernel - Re: [PATCH] net: dsa: ocelot: fix selecting MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+0IT/bV7snqCmnF@COLIN-DESKTOP1.localdomain>
Date:   Wed, 15 Feb 2023 08:29:03 -0800
From:   Colin Foster <colin.foster@...advantage.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: ocelot: fix selecting MFD_OCELOT

Hi Lukas,

On Wed, Feb 15, 2023 at 11:46:31AM +0100, Lukas Bulwahn wrote:
> Commit 3d7316ac81ac ("net: dsa: ocelot: add external ocelot switch
> control") adds config NET_DSA_MSCC_OCELOT_EXT, which selects the
> non-existing config MFD_OCELOT_CORE.
> 
> Replace this select with the intended and existing MFD_OCELOT.

Thanks for this. We pivoted away from *_CORE a while back and I clearly
missed this. It can go through net-next this week.

Acked-by: Colin Foster <colin.foster@...advantage.com>

> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>  drivers/net/dsa/ocelot/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig
> index eff0a7dfcd21..081e7a88ea02 100644
> --- a/drivers/net/dsa/ocelot/Kconfig
> +++ b/drivers/net/dsa/ocelot/Kconfig
> @@ -14,7 +14,7 @@ config NET_DSA_MSCC_OCELOT_EXT
>  	depends on NET_VENDOR_MICROSEMI
>  	depends on PTP_1588_CLOCK_OPTIONAL
>  	select MDIO_MSCC_MIIM
> -	select MFD_OCELOT_CORE
> +	select MFD_OCELOT
>  	select MSCC_OCELOT_SWITCH_LIB
>  	select NET_DSA_MSCC_FELIX_DSA_LIB
>  	select NET_DSA_TAG_OCELOT_8021Q
> -- 
> 2.17.1
>