linux-kernel - Re: [PATCH v4 2/4] arm64: dts: qcom: sc8280xp-crd: Introduce pmic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+0W9U8lIhTH1xik@hovoldconsulting.com>
Date:   Wed, 15 Feb 2023 18:31:33 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Bjorn Andersson <quic_bjorande@...cinc.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 2/4] arm64: dts: qcom: sc8280xp-crd: Introduce
 pmic_glink

On Wed, Feb 15, 2023 at 09:23:47AM -0800, Bjorn Andersson wrote:
> On Wed, Feb 15, 2023 at 10:47:40AM +0100, Johan Hovold wrote:
> > On Mon, Feb 13, 2023 at 01:56:17PM -0800, Bjorn Andersson wrote:
> [..]
> > > +&mdss0_dp0_out {
> > > +	data-lanes = <0 1>;
> > 
> > This does not work as the drm driver expects 'data-lanes' to be defined
> > in the controller node where you had it in the previous versions:
> > 
> > 	[    6.669325] [drm] Invalid property "data-lanes", default max DP lanes = 4
> > 
> > Moving it to the endpoint nodes would require updating both binding and
> > driver it seems.
> > 
> 
> I will go back and double-check, but this should be taken care of in
> d25cfeeec064 ("drm/msm/dp: parse data-lanes as property of dp_out
> endpoint").

That indeed seems to be the case. Sorry about the noise.

I'll just carry the fixes I posted for my sc8280xp 6.2 branches.

Johan