linux-kernel - Re: [PATCH 11/11] x86/sev: Change snp_guest_issue_request()'s fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+5g6Hjm9oxRjwJX@zn.tnic>
Date:   Thu, 16 Feb 2023 17:59:20 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Dionna Glaze <dionnaglaze@...gle.com>,
        Joerg Roedel <jroedel@...e.de>,
        Michael Roth <michael.roth@....com>,
        Nikunj A Dadhania <nikunj@....com>,
        Peter Gonda <pgonda@...gle.com>,
        Tom Lendacky <Thomas.Lendacky@....com>,
        linux-coco@...ts.linux.dev, x86@...nel.org
Subject: Re: [PATCH 11/11] x86/sev: Change snp_guest_issue_request()'s fw_err
 argument

On Thu, Feb 16, 2023 at 01:46:02PM +0100, Borislav Petkov wrote:
> @@ -390,18 +390,16 @@ static int __handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code,
>  		goto retry_request;
>  	}
>  
> -	if (fw_err)
> -		*fw_err = override_err ?: err;
> -

As Tom pointed out offlist, we still need to do the error override.
Frankly, I'm not crazy about this request retrying as we do it but
I guess it is what it is and it is too late to change that now.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette