linux-kernel - Re: [Patch] [testing][wireguard] Remove unneeded version.h include pointed out by 'make versioncheck'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <597822c9-b859-7a08-6987-1d8a552f6f32@intel.com>
Date:   Thu, 16 Feb 2023 18:05:53 +0100
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Jesper Juhl <jesperjuhl76@...il.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
        <netdev@...r.kernel.org>, <wireguard@...ts.zx2c4.com>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Shuah Khan <shuah@...nel.org>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [Patch] [testing][wireguard] Remove unneeded version.h include
 pointed out by 'make versioncheck'

From: Jesper Juhl <jesperjuhl76@...il.com>
Date: Thu, 16 Feb 2023 02:01:05 +0100 (CET)

>> From e2fa4955c676960d0809e4afe8273075c94451c9 Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <jesperjuhl76@...il.com>
> Date: Mon, 13 Feb 2023 02:58:36 +0100
> Subject: [PATCH 06/12] [testing][wireguard] Remove unneeded version.h
> include
>  pointed out by 'make versioncheck'

Your patch is broken, pls resend.
Also I've no idea about the subject/prefix, shouldn't it be like:

[PATCH net-next] wireguard: selftests: remove unneeded version.h

?

> 
> Signed-off-by: Jesper Juhl <jesperjuhl76@...il.com>
> ---
>  tools/testing/selftests/wireguard/qemu/init.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/wireguard/qemu/init.c
> b/tools/testing/selftests/wireguard/qemu/init.c
> index 3e49924dd77e..20d8d3192f75 100644
> --- a/tools/testing/selftests/wireguard/qemu/init.c
> +++ b/tools/testing/selftests/wireguard/qemu/init.c
> @@ -24,7 +24,6 @@
>  #include <sys/sysmacros.h>
>  #include <sys/random.h>
>  #include <linux/random.h>
> -#include <linux/version.h>
> 
>  __attribute__((noreturn)) static void poweroff(void)
>  {

Thanks,
Olek