linux-kernel - Re: [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+5lptaM0cnj+WBi@lunn.ch>
Date:   Thu, 16 Feb 2023 18:19:34 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>
Cc:     Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org,
        linux@...tq-group.com
Subject: Re: [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register
 through io_base

> -	i2c_det = ioread8(io_base + TQMX86_REG_I2C_DETECT);
> +	i2c_det = inb(TQMX86_REG_I2C_DETECT);

I think it would be good to add a comment, since it now looks out of
place compared to all the other ioread8().

      Andrew